Proposals for Collapse, CollapseAll, Expand APIs #61626
Conversation
| export function createTreeView<T>(viewId: string, options: { treeDataProvider: TreeDataProvider<T> }): TreeView2<T>; | ||
| } | ||
|
|
||
| export interface TreeView2<T> extends TreeView<T> { |
There was a problem hiding this comment.
You seem to like the 2 suffix but I think that's not really needed...
There was a problem hiding this comment.
I tried using the same name
| export interface TreeView2<T> extends TreeView<T> { | |
| export interface TreeView<T> extends TreeView<T> { |
but it caused recursive compilation error. Do you have other suggestions?
| /** | ||
| * Collapse all elements. | ||
| */ | ||
| collapseAll(): Thenable<void>; |
There was a problem hiding this comment.
maybe just another overload, like collapse()
There was a problem hiding this comment.
Tried this but felt weird collapse does collapsing all.
| * @param elementOrElements element(s) to collpase. | ||
| * @param recursive Controls if elements have to be collapsed recursively or not. | ||
| */ | ||
| collapse(elementOrElements: T | T[], recursive?: boolean): Thenable<void>; |
There was a problem hiding this comment.
Why Thenable? Is this us leaking tree implementation details?
There was a problem hiding this comment.
expand is async and to be consistent I made collapse also. In fact collapse is async in the current tree impl. Not returning Thenable might cause authors to think it sync and can lead to unexpected errors.
|
@sandy081 You can just merge proposed api changes, we will discuss them in the API call, and lets have a PR when merging this to stable |
Implements #55879