Support Vuejs file (fix #6290) #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yyx990803 Is that really appropriate? |
|
I guess it doesn't hurt as long as it doesn't interfere when the user explicitly installs https://github.com/LiuJi-Jim/vscode-vue |
| @@ -11,7 +11,7 @@ import ConfigurationRegistry = require('vs/platform/configuration/common/configu | |||
|
|
|||
| ModesRegistry.registerCompatMode({ | |||
| id: 'html', | |||
| extensions: ['.html', '.htm', '.shtml', '.mdoc', '.jsp', '.asp', '.aspx', '.jshtm'], | |||
There was a problem hiding this comment.
Is it a problem that .xhtml isn't here?
There was a problem hiding this comment.
@Tyriar Thank you. Now, I added .xhtml.
|
I tested the fix togther with the https://github.com/LiuJi-Jim/vscode-vue extension. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6290.
Vuejs file is like HTML.
And this related #6191 and #4700.