chore: update tsc target

[LeuisKen]

Update tsc target to "es2017" since vscode now using electorn 4.2.7
which based on chromium@68 and [email protected].

This will enable more esnext features and reduce the bundle size.

According to: https://kangax.github.io/compat-table/es2016plus/

[jrieken]

Ran two builds to compare file sizes of our main bundle: before 6027569bytes, after 5994648bytes. That's less what I have expected but the awesome news is that async/await is now just as-is, no more yield, no more state machine.

[bpasero]

Why not go for ES2018, we actually seem to be using that already for all of our extensions, even though some seem to explicitly set a target:

vscode/extensions/shared.tsconfig.json

Line 3 in 20dd80d

"target": "es2018",

I think:

• core should move to ES2018
• every extension should import the shared one
• no extension should overwrite the target

[LeuisKen]

I agree with @bpasero 's views.

[jrieken]

Using es2018 yields in 5992860bytes but it seems that dev tools fails to pretty print the minified file, e.g you must use source maps which isn't an option for everyone.

[LeuisKen]

it seems that dev tools fails to pretty print the minified file, e.g you must use source maps which isn't an option for everyone.

Yes, I also reproduce this problem on Chrome 76, so we can't fix this problem by using latest electron...
So what to do with this problem, shall I revert the "target" to "es2017" ?

BTW: I find that the JavaScriptFormatter in Chrome Dev Tool has not been updated since 2018, maybe I could try to make a patch to handle our case.

[bpasero]

@jrieken

Using es2018 yields in 5992860bytes but it seems that dev tools fails to pretty print the minified file, e.g you must use source maps which isn't an option for everyone.

To clarify: using ES2018 results in issues when looking at minified code? But we always ship with sourcemaps no?

[jrieken]

Well, when there is the need to debug minified code (because the issue is so obscure) then I don't trust source maps (they have failed me soo many times) and I want JS code.

[bpasero]

Yeah I saw this issue in action, weird. Even reproduces with latest E6 builds. Looks like a bug in DevTools to me.

[jrieken]

Yeah, sure an issue with dev tools. We can revisit this when we have a newer version or when we swap the minifier.

[LeuisKen]

I create a issue for this: https://bugs.chromium.org/p/chromium/issues/detail?id=999794

[bpasero]

Thanks for doing that ❤️

[WSLUser]

you can switch to 2018 now. The bug says it's been fixed and has changed to using 2018.