Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9482: AutoClosePair between tags #9535

Closed

Conversation

formulahendry
Copy link
Member

@formulahendry formulahendry commented Jul 20, 2016

Fix #9482
This is a very common scenario when users use Emmet or Auto Close Tag Extension. The cursor is just before the <.

Before Fix:

beforeFix

After Fix:

afterFix

VS IDE behavior:

beforeFix

@msftclas
Copy link

Hi @formulahendry, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@formulahendry
Copy link
Member Author

Ping @alexandrudima , any feedback? 😃

@alexdima alexdima assigned joaomoreno and unassigned alexdima Aug 16, 2016
@alexdima
Copy link
Member

Sorry, wrong assignment, @joaomoreno added that feature to the editor

@joaomoreno joaomoreno added this to the September 2016 milestone Aug 16, 2016
@formulahendry
Copy link
Member Author

Never mind. @alexandrudima
@joaomoreno Look forward to your feedback. 😄

@formulahendry
Copy link
Member Author

Ping @joaomoreno 😃

@joaomoreno
Copy link
Member

@alexandrudima That may be true, but I haven't seen/touched this code for over 3 years. I feel highly under qualified to do anything with it. At some point we should sit, you give me a tour and I can tackle its issues.

@formulahendry This doesn't seem to fix anything except the special HTML case, deep down in the editor's code. Sorry but won't merge it.

@joaomoreno joaomoreno closed this Sep 13, 2016
@alexdima
Copy link
Member

@joaomoreno Sure, over the years I have kept the code compiling as I did various refactorings, but I did not touch the logic. The relevant methods are:

  • _typeInterceptorAutoClosingCloseChar
  • _typeInterceptorAutoClosingOpenChar
  • _typeInterceptorSurroundSelection
  • _autoClosingPairDelete

in oneCursor.ts

I had to adopt their external shape, but I did not touch the logic. If you wish I can find them at the version they were added and present a diff.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing brackets between tags
4 participants