Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft.Extensions.DependencyModel dependency to test host nuspec #444

Merged
merged 4 commits into from
Feb 13, 2017

Conversation

smadala
Copy link
Contributor

@smadala smadala commented Feb 6, 2017

Fixes #393.
Should be merged after xUnit PlatformAbstraction fix release because DependencyModel 1.1 will break xUnit with error
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.DotNet.InternalAbstractions, Version=1.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60.

Related issues: xunit/xunit#1080, xunit/xunit#1088

/cc @srivatsn @sbaid

@msftclas
Copy link

msftclas commented Feb 6, 2017

Hi @smadala, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Satya Madala). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@smadala
Copy link
Contributor Author

smadala commented Feb 6, 2017

@onovotny Can you please provide tentative date for visualstudio.xunit 2.2-beta6 release?

@codito
Copy link
Contributor

codito commented Feb 8, 2017

We need to take this for rtw.

@Faizan2304 this change requires the following as well?

  • CrossPlatEngine refers DependencyModel 1.1.0 in 15.0-rtm branch
  • Dotnet-CLI repo builds with DependencyModel 1.1.0

/cc @livarcocc

@davidfowl
Copy link

Is this already fixed? When is it going in?

@clairernovotny
Copy link
Member

@davidfowl xunit beta6/RC has this fix already. The latest MyGet feed has it. I believe @bradwilson is publishing a quick RC any day now followed by the stable 2.2 ver.

@smadala smadala merged commit 9a24bf9 into microsoft:master Feb 13, 2017
@smadala smadala deleted the nuspec-02 branch February 13, 2017 13:19
smadala added a commit to smadala/vstest that referenced this pull request Feb 13, 2017
@Faizan2304
Copy link
Contributor

@Faizan2304 this change requires the following as well?
CrossPlatEngine refers DependencyModel 1.1.0 in 15.0-rtm branch
Dotnet-CLI repo builds with DependencyModel 1.1.0

Yes we should but some how its working without second point Dotnet-CLI repo builds with DependencyModel 1.1.0

smadala added a commit that referenced this pull request Feb 13, 2017
…ec (#475)

* Add Microsoft.Extensions.DependencyModel dependency to test host nuspec (#444)

* Upgrade DepencencyModel version to 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build warning on build of default xunit template (netcore)
6 participants