-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft.Extensions.DependencyModel dependency to test host nuspec #444
Conversation
Hi @smadala, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
@onovotny Can you please provide tentative date for visualstudio.xunit 2.2-beta6 release? |
We need to take this for rtw. @Faizan2304 this change requires the following as well?
/cc @livarcocc |
Is this already fixed? When is it going in? |
@davidfowl xunit beta6/RC has this fix already. The latest MyGet feed has it. I believe @bradwilson is publishing a quick RC any day now followed by the stable 2.2 ver. |
Yes we should but some how its working without second point |
Fixes #393.
Should be merged after xUnit PlatformAbstraction fix release because DependencyModel 1.1 will break xUnit with error
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.DotNet.InternalAbstractions, Version=1.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60
.Related issues: xunit/xunit#1080, xunit/xunit#1088
/cc @srivatsn @sbaid