-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CNI config 1.0.0 support. #101
Conversation
Note that this is only a dependency update which does NOT enable reading CNI configs > 0.3.0. Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
6a7a374
to
7fe81d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, for all the work!
@debj1t is there a way I can test this out? I would like to get an archive with the artefacts |
@nicolaerosia back in December I had written this workflow running containerd's integration tests against the plugins. Looking at one of my latest runs, the NOTE: there is a slight issue with the naming of the plugins not coinciding with the HNS network types, so you will need to also include this other PR in your testing. (it was the final blocker which prevented full integration with containerd before I left the project) Hope this helped a bit, godspeed! |
Could you please make a release with these changes? It is required for nerdctl, see containerd/nerdctl#28 (comment) |
See containerd/nerdctl#28 (comment) We're waiting for a release that contains changes from microsoft/windows-container-networking#101
This PR updates the
containernetwork/cni
dependency to 1.1.2 and adds support for reading CNI configs of up to 1.0.0.Note that, although the "CHECK" verb had an entry point added for it it, it is currently no-op.