Exit the loc choice loop if the default localization is good enough (#…

…1500)
microsoft · Sep 23, 2021 · 3ffb45c · 3ffb45c
1 parent 810a441
commit 3ffb45c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/AppInstallerCommonCore/Manifest/Manifest.cpp b/src/AppInstallerCommonCore/Manifest/Manifest.cpp
@@ -38,9 +38,12 @@ namespace AppInstaller::Manifest
             }
 
             // If there's better locale than default And is compatible with target locale, merge and return;
-            if (bestLocalization != nullptr && bestScore >= Locale::MinimumDistanceScoreAsCompatibleMatch)
+            if (bestScore >= Locale::MinimumDistanceScoreAsCompatibleMatch)
             {
-                CurrentLocalization.ReplaceOrMergeWith(*bestLocalization);
+                if (bestLocalization != nullptr)
+                {
+                    CurrentLocalization.ReplaceOrMergeWith(*bestLocalization);
+                }
                 break;
             }
         }