Skip to content

Commit

Permalink
update signing
Browse files Browse the repository at this point in the history
  • Loading branch information
@ryfu-msft
ryfu-msft committed Jun 28, 2024
1 parent a7f7c21 commit 7749000
Showing 1 changed file with 20 additions and 10 deletions.
30 changes: 20 additions & 10 deletions azure-pipelines.nuget.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,15 @@ jobs:
solution: "$(solution)"
configuration: "$(buildConfiguration)"

- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@2
- task: EsrpCodeSigning@5
displayName: "ESRP CodeSigning - Package contents"
inputs:
ConnectedServiceName: "WindowsPackageManager ESRP CodeSigning"
AppRegistrationClientId: '32216f16-efc9-4013-9fae-c6a2c54a3fc0'
AppRegistrationTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47'
AuthAKVName: 'PeetDevOpsKeyVault'

Check failure on line 90 in azure-pipelines.nuget.yml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`Peet` is not a recognized word. (unrecognized-spelling)

Check failure on line 90 in azure-pipelines.nuget.yml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`AKV` is not a recognized word. (unrecognized-spelling)
AuthCertName: 'ESRPAuth'
AuthSignCertName: 'ESRPRequestSigning'
FolderPath: src
Pattern: |
*\$(buildConfiguration)\WinGetUtil\WinGetUtil.dll
Expand Down Expand Up @@ -161,10 +166,15 @@ jobs:
packDestination: '$(Build.ArtifactStagingDirectory)'
basePath: $(Pipeline.Workspace)

- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@2
- task: EsrpCodeSigning@5
displayName: "ESRP CodeSigning - NuGet package"
inputs:
ConnectedServiceName: "WindowsPackageManager ESRP CodeSigning"
AppRegistrationClientId: '32216f16-efc9-4013-9fae-c6a2c54a3fc0'
AppRegistrationTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47'
AuthAKVName: 'PeetDevOpsKeyVault'

Check failure on line 175 in azure-pipelines.nuget.yml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`Peet` is not a recognized word. (unrecognized-spelling)

Check failure on line 175 in azure-pipelines.nuget.yml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`AKV` is not a recognized word. (unrecognized-spelling)
AuthCertName: 'ESRPAuth'
AuthSignCertName: 'ESRPRequestSigning'
FolderPath: "$(Build.ArtifactStagingDirectory)"
Pattern: "$(packageName).$(version).nupkg"
signConfigType: inlineSignParams
Expand Down Expand Up @@ -193,11 +203,11 @@ jobs:
ArtifactName: $(packageName)
publishLocation: Container

- task: NuGetCommand@2
displayName: Push WingetUtil nuget package to nuget.org
inputs:
command: push
nuGetFeedType: external
includeNugetOrg: true
packagesToPush: '$(Build.ArtifactStagingDirectory)\$(packageName).$(version).nupkg'
publishFeedCredentials: "WindowsPackageManagerAzurePipelineNuget - NuGet.org"
# - task: NuGetCommand@2
# displayName: Push WingetUtil nuget package to nuget.org
# inputs:
# command: push
# nuGetFeedType: external
# includeNugetOrg: true
# packagesToPush: '$(Build.ArtifactStagingDirectory)\$(packageName).$(version).nupkg'
# publishFeedCredentials: "WindowsPackageManagerAzurePipelineNuget - NuGet.org"

1 comment on commit 7749000

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log for details.

Unrecognized words (2)

AKV
Peet

Previously acknowledged words that are now absent ata bitspace EPester epth hrow issuetitle mapview Mta oop PFM rzkzqaqjwj sfs STARTUPINFOW testdata visualstudiocode :arrow_right:
Some files were automatically ignored

These sample patterns would exclude them:

^\Qsrc/AppInstallerCLIE2ETests/TestData/AppInstallerTestMsiInstallerV2.msi\E$

You should consider adding them to:

.github/actions/spelling/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:microsoft/winget-cli.git repository
on the user/ryfu/fixNugetPipeline branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/winget-cli/actions/runs/9716991121/attempts/1'
Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (552) from .github/actions/spelling/expect.txt and unrecognized words (2)

Dictionary Entries Covers
cspell:win32/src/win32.txt 53509 20
cspell:python/src/python/python-lib.txt 3873 3
cspell:python/src/python/python.txt 453 2
cspell:python/src/common/extra.txt 741 2
cspell:php/php.txt 2597 2
cspell:npm/npm.txt 288 2
cspell:django/django.txt 859 2
cspell:csharp/csharp.txt 19 2
cspell:sql/src/tsql.txt 455 1
cspell:scala/scala.txt 833 1

Consider adding them using (in .github/workflows/spelling3.yml):

      with:
        extra_dictionaries:
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:python/src/python/python.txt
          cspell:python/src/common/extra.txt
          cspell:php/php.txt
          cspell:npm/npm.txt
          cspell:django/django.txt
          cspell:csharp/csharp.txt
          cspell:sql/src/tsql.txt
          cspell:scala/scala.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
Warnings (2)

See the 📜action log for details.

ℹ️ Warnings Count
ℹ️ binary-file 1
ℹ️ unexpected-line-ending 3

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Please sign in to comment.