Explicitly close file stream on FileLogger destruction (#3424)

microsoft · Jul 11, 2023 · bb0a746 · bb0a746
1 parent b82cf60
commit bb0a746
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/AppInstallerCommonCore/FileLogger.cpp b/src/AppInstallerCommonCore/FileLogger.cpp
@@ -37,6 +37,9 @@ namespace AppInstaller::Logging
     FileLogger::~FileLogger()
     {
         m_stream.flush();
+        // When std::ofstream is constructed from an existing File handle, it does not call fclose on destruction
+        // Only calling close() explicitly will close the file handle.
+        m_stream.close();
     }
 
     std::string FileLogger::GetNameForPath(const std::filesystem::path& filePath)