Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color contamination to the console if the program was terminated by Ctrl+C #494

Closed
yfdyh000 opened this issue Jul 14, 2020 · 5 comments · Fixed by #1527
Closed

Color contamination to the console if the program was terminated by Ctrl+C #494

yfdyh000 opened this issue Jul 14, 2020 · 5 comments · Fixed by #1527
Assignees
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback Issue needs attention from issue or PR author No-Recent-Activity Issue has no recent activity
Milestone

Comments

@yfdyh000
Copy link

Color contamination to the console if the program was terminated by Ctrl+C

Steps to reproduce

Run winget source list update, or winget search [name] (while cache is not ready) in cmd window.
While like "/" status, press Ctrl+C hotkey to terminate it, probably due to slowness.

Expected behavior

Reset the character color to normal when the program is terminated.

Actual behavior

The new characters remain blue.

Environment

程序包: Microsoft.DesktopAppInstaller v1.0.41821.0

In China, I see the winget source update often takes tens of seconds or minutes to complete. Only the https://winget.azureedge.net/cache configured and it is accessible from browser.

@ghost ghost added the Needs-Triage Issue need to be triaged label Jul 14, 2020
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Jul 14, 2020
@denelon denelon added this to the Package Manager Backlog milestone Jul 14, 2020
@denelon
Copy link
Contributor

denelon commented Jul 14, 2020

@yfdyh000 thanks for pointing this out. By the way, you can configure the TTL on the cache refresh with this version of the client in settings. We've been looking at bandwidth issues recently.

@denelon
Copy link
Contributor

denelon commented Apr 22, 2021

@yfdyh000 is this still happening. We believe this may have been fixed in an earlier release.

@denelon denelon added the Needs-Author-Feedback Issue needs attention from issue or PR author label Apr 22, 2021
@ghost ghost added the No-Recent-Activity Issue has no recent activity label Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@denelon denelon linked a pull request Sep 14, 2021 that will close this issue
@ghost ghost removed the No-Recent-Activity Issue has no recent activity label Sep 23, 2021
@ghost ghost added the No-Recent-Activity Issue has no recent activity label Sep 30, 2021
@ghost
Copy link

ghost commented Sep 30, 2021

@yfdyh000 this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@denelon denelon modified the milestones: Backlog-Client, v1.2-Client Oct 1, 2021
@ghost ghost removed the No-Recent-Activity Issue has no recent activity label Oct 1, 2021
@ghost ghost added the No-Recent-Activity Issue has no recent activity label Oct 9, 2021
@ghost
Copy link

ghost commented Oct 9, 2021

@yfdyh000 this issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@denelon denelon linked a pull request Oct 19, 2021 that will close this issue
@denelon denelon closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback Issue needs attention from issue or PR author No-Recent-Activity Issue has no recent activity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants