Color contamination fix #1527
Merged
Color contamination fix #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 28, 2021 19:33
… user/akalagbe/color-contamination-fix-2
added 2 commits
September 29, 2021 22:27
… user/akalagbe/color-contamination-fix-2
JohnMcPMS
requested changes
Oct 1, 2021
| } | ||
|
|
||
| NoVTStream& operator<<(std::ostream& (__cdecl* f)(std::ostream&)); | ||
| NoVTStream& operator<<(const VirtualTerminal::Sequence& sequence) = delete; |
There was a problem hiding this comment.
The other thing that the NoVTStream did was make it a compile error to attempt to output a VT sequence. Not the end of the world to not have it, but I do like the very early notification that it won't work.
ghost
added
the
Needs-Author-Feedback
added 2 commits
October 5, 2021 10:25
… user/akalagbe/color-contamination-fix-2
ghost
removed
the
Needs-Author-Feedback
JohnMcPMS
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset console to default color when user force quits(hits ctrl + c twice) during execution.
Channel all console output write operations only through OutputStream/BaseStream wrappers.
Deleted NoVTStream.
Microsoft Reviewers: Open in CodeFlow