Add projected winrt wrapper for server com interface and add tests #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge microsoft/winget-cli changes.
Rest endpoint helper and json object field check - Bug fix (microsoft#821)
Merge latest winget changes.
This comment has been minimized.
This comment has been minimized.
sreadingMSFT
commented
Aug 16, 2021
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net5.0</TargetFramework> | |||
There was a problem hiding this comment.
Oops. Changes in this file are from an attempt to re-use the existing tests. Will revert. #Pending
sreadingMSFT
commented
Aug 16, 2021
| @@ -533,5 +533,9 @@ namespace Microsoft.Management.Deployment | |||
| interface Windows.Foundation.Collections.IVectorView<PackageVersionId>; | |||
| interface Windows.Foundation.Collections.IVector<PackageVersionInfo>; | |||
| interface Windows.Foundation.Collections.IVectorView<PackageVersionInfo>; | |||
| interface Windows.Foundation.Collections.IVector<PackageVersionId>; | |||
There was a problem hiding this comment.
Bad merge I guess. Will revert. #Pending
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server com interface is wrapped with a winrt dll that just overrides the factory implementation to create the server com classes. Given that implementation there is currently no optimization of client\server communication. If necessary that will need to be explored in a separate checkin. This change also creates the framework for adding tests, with a new test project that runs inside a package. I added a few simple ones here for demonstration purposes but will do the rest in a separate checkin.
Due to unresolved issues on the build server the PackageCom interface that should be registered by the WinGetDev package is not showing up as registered, so the tests are unable to call that. To workaround this issue I've built a version of the WindowsPackageManagerServer.exe as a dll, Microsoft.Management.Deployment.Server.Test.dll, and then included it in the PackagedTests project directly. By giving that project the runFullTrust permission, the test package itself becomes equivalent to the WinGetDev package. Unfortunately this means the com communication itself still does not have automated testing, but the vast majority of the com interface code base is in the Microsoft.Management.Deployment project which is now testable.
Microsoft Reviewers: Open in CodeFlow