Handle single unknown version from REST source #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
If a REST source returns a single version that is
Unknown, look up all versions when the manifest is requested.Unfortunately I moved the code around due to the implementation and this looks like a lot more change than it is. Things I actually changed are:
PackageBaseintoAvailablePackageas there are no other derived types.PackageVersionhold astd::shared_ptr<AvailablePackage>rather than the info.AvailablePackage.The update is triggered by a
GetManifestcall that meets the criteria (version isUnknownand manifest is missing). When we see that, and the version info in the package is consistent, we perform an optimized search that should return the versions and manifests. Then we overwrite the data from thePackageVersionthat called us and it returns the manifest.Validation
Manually ensured that the failing scenario is functioning now.
Microsoft Reviewers: Open in CodeFlow