Fixed bug where the package name wouldn't be written during upgrade. #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
florelis
approved these changes
Sep 28, 2021
JohnMcPMS
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the latest build, the package name wouldn't print during
winget upgrade(well, it'd print with the agreements portion, but it would not print after that when the package was actually being installed) :I figured it was easy enough to fix myself, and it was!
package.PackageVersion->GetManifest())was being used wherepackage.Manifestshould've been used (so that the locale info would be available).Look at it now:
Let me know if there are any issues!
Microsoft Reviewers: Open in CodeFlow