-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair-WinGetPackageManager improvements #3423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
Jul 12, 2023
src/PowerShell/Microsoft.WinGet.Client.Engine/Commands/WinGetPackageManagerCommand.cs
Outdated
Show resolved
Hide resolved
JohnMcPMS
approved these changes
Jul 13, 2023
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #3374
Change
Repair-WinGetPackageManager
repair known issues until its fixed or there's a non fixable state.Microsoft.UI.Xaml.2.7
package from their GitHub release.-AllUsers
toRepair-WinGetPackageManager
. If this is on, repair usesAdd-AppxProvisionedPackage
instead ofAdd-AppxPackage
.winget.exe
failures due to missing license. To fix itRepair-WinGetPackageManager -AllUsers
must be executed in admin mode.Repair-WinGetPackageManager
to always fail for Windows PowerShell.Repair-WinGetPackageManager
. It will now throw if there's an issue repairing. Good thing this is a "prerelease" module 🗡️Validation
Test locally on machines where Microsoft.UI.Xaml.2.7 was not preinstalled and on Windows Server 2022.
Microsoft Reviewers: codeflow:open?pullrequest=#3423