Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair-WinGetPackageManager improvements #3423

Merged
merged 10 commits into from
Jul 14, 2023

Conversation

msftrubengu
Copy link
Contributor

@msftrubengu msftrubengu commented Jul 10, 2023

This PR address #3374

Change

  • Make Repair-WinGetPackageManager repair known issues until its fixed or there's a non fixable state.
  • Adds support for installing Microsoft.UI.Xaml.2.7 package from their GitHub release.
  • Adds new parameter switch -AllUsers to Repair-WinGetPackageManager. If this is on, repair uses Add-AppxProvisionedPackage instead of Add-AppxPackage.
  • Adds new integrity category to detect winget.exe failures due to missing license. To fix it Repair-WinGetPackageManager -AllUsers must be executed in admin mode.
  • Fix adding preprocessor macros for net48. This cause Repair-WinGetPackageManager to always fail for Windows PowerShell.
  • There's a breaking change in Repair-WinGetPackageManager. It will now throw if there's an issue repairing. Good thing this is a "prerelease" module 🗡️

Validation

Test locally on machines where Microsoft.UI.Xaml.2.7 was not preinstalled and on Windows Server 2022.

Microsoft Reviewers: codeflow:open?pullrequest=#3423

@msftrubengu msftrubengu requested a review from a team as a code owner July 10, 2023 22:38
@github-actions

This comment has been minimized.

@msftrubengu
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msftrubengu msftrubengu merged commit d637f0e into microsoft:master Jul 14, 2023
8 checks passed
@msftrubengu msftrubengu deleted the repair branch August 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants