Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give System and Admins full access to state folders #3471

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

yao-msft
Copy link
Contributor

@yao-msft yao-msft commented Jul 25, 2023

Manually validated the folders have System and Admin access after the change.
This pr could be merged after approval from Intune security team.

Microsoft Reviewers: codeflow:open?pullrequest=#3471

@yao-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 3471 in repo microsoft/winget-cli

@yao-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 3471 in repo microsoft/winget-cli

@yao-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 3471 in repo microsoft/winget-cli

@yao-msft
Copy link
Contributor Author

Try close and reopen

@yao-msft yao-msft closed this Jul 26, 2023
@yao-msft yao-msft reopened this Jul 26, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 26, 2023
@Trenly
Copy link
Contributor

Trenly commented Jul 27, 2023

I've seen a rebase with a force push work occasionally in the past

@yao-msft yao-msft marked this pull request as draft August 1, 2023 20:07
@yao-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

JohnMcPMS
JohnMcPMS previously approved these changes Sep 3, 2023
@yao-msft
Copy link
Contributor Author

yao-msft commented Sep 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft marked this pull request as ready for review September 5, 2023 03:43
@yao-msft yao-msft merged commit 8ee3db1 into microsoft:master Sep 5, 2023
8 checks passed
@yao-msft yao-msft deleted the statefolderacl branch September 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
5 participants