Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependencies, windows feature, and download experimental features stable #3545

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Aug 22, 2023

Removed the experimental feature flag for dependencies, windows feature, and download.

  • Added an override for windows feature since some of the existing test manifests included a windows feature which should not be enabled.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner August 22, 2023 19:50
@ryfu-msft ryfu-msft marked this pull request as draft August 22, 2023 22:34
@ryfu-msft ryfu-msft marked this pull request as ready for review August 24, 2023 15:48
@ryfu-msft ryfu-msft changed the title Make dependencies experimental feature stable Make dependencies, windows feature, and download experimental features stable Aug 24, 2023
yao-msft
yao-msft previously approved these changes Aug 25, 2023
"directMSI": {
"description": "Enable use of MSI APIs rather than msiexec for MSI installs",
"type": "boolean",
"default": false
},
"configuration": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong feature removed?

@ryfu-msft ryfu-msft merged commit 869c3d9 into microsoft:master Aug 29, 2023
8 checks passed
@ryfu-msft ryfu-msft deleted the EFDependencies branch August 29, 2023 15:27
This was linked to issues Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Features (WSL) winget download
2 participants