Attempt to update dependencies when not registered #4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftrubengu
approved these changes
Jul 2, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4337
Change
Before registering the package for repair, ensure that the dependencies are present and in good standing. Fortunately, the existing function to install the dependencies does this, so we just call it.
Validation
Successfully repaired a machine in the state described in #4337 (provisioned, "registered" for the user, but Xaml 2.8 missing).
[Was not 100% successful since I forgot to build the production version and it wanted to find
wingetdev.exe, but verified manually that the repair succeeded.]Microsoft Reviewers: Open in CodeFlow