Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create public sample #4734

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Create public sample #4734

merged 4 commits into from
Aug 14, 2024

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Aug 14, 2024

Change

Copy the current dev tool, COM calling application into a new location and update significantly with the goal of being a public sample of usage. Cleaned up the code and tried to include more error handling and commenting.

Major changes to the UX:

  • Removed the dev switch as this is intended as a public sample
  • Added example search options selection
  • Add Upgrade button so that function could be called as well
  • Add Uninstall button for installed packages
  • Disconnected installed and active operation lists from catalog selection and package search

Major change to DevX:

  • Move to using the OOP COM nuget package
    • This isn't ready for use yet, as the OOP activation dll isn't available in a public version yet and we are still working on the exact shape of that update.

Validation

Everything is at least functional on the golden path, as verified manually.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner August 14, 2024 00:41
@JohnMcPMS JohnMcPMS merged commit 095b221 into microsoft:master Aug 14, 2024
4 checks passed
@JohnMcPMS JohnMcPMS deleted the public-sample branch August 14, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants