Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External HR error message support #4746

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Aug 20, 2024

Fixes #3982

Change

Add support for externally defined HRESULTs to have a custom message. Use this to provide a message for the errors associated with a Microsoft Store package being unavailable for the current system.

Validation

Manually confirmed that GetUserPresentableMessageForHR will get the intended message.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner August 20, 2024 23:29
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Feature This is a feature request for the Windows Package Manager client. label Aug 20, 2024
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit d010e24 into microsoft:master Aug 21, 2024
9 checks passed
@JohnMcPMS JohnMcPMS deleted the store-appl branch August 21, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinGet error reporting reports applicability error when encountered
2 participants