Workflow improvements to increase winget command success rate #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranm-msft
reviewed
Nov 26, 2020
| @@ -135,7 +164,8 @@ namespace AppInstaller::CLI::Workflow | |||
| } | |||
| catch (const winrt::hresult_error& e) | |||
| { | |||
| if (e.code() == HRESULT_FROM_WIN32(ERROR_NO_RANGES_PROCESSED)) | |||
| if (e.code() == HRESULT_FROM_WIN32(ERROR_NO_RANGES_PROCESSED) || | |||
| HRESULT_FACILITY(e.code()) == FACILITY_HTTP) | |||
| { | |||
| // Server does not support range request, use download | |||
There was a problem hiding this comment.
support range request [](start = 35, length = 21)
update comment #Resolved
ranm-msft
reviewed
Nov 26, 2020
| auto result = context.Reporter.ExecuteWithProgress(std::bind(Repository::OpenSource, sourceName, std::placeholders::_1), true); | ||
| source = result.Source; | ||
|
|
||
| for (const auto& s : result.SourcesWithUpdateFailure) |
There was a problem hiding this comment.
for [](start = 12, length = 3)
add a comment indicating that this is only going to produce a warning but we'll continue with the operation (install/update etc.) #Resolved
ranm-msft
reviewed
Nov 26, 2020
| // Check download size matches if content length is provided in response header | ||
| if (contentLength > 0) | ||
| { | ||
| THROW_HR_IF(E_UNEXPECTED, bytesDownloaded != contentLength); |
There was a problem hiding this comment.
E_UNEXPECTED [](start = 24, length = 12)
let's create a new hresult reflecting the actual error of size mismatch
DOWNLOAD_SIZE_MISMATCH #Resolved
ranm-msft
reviewed
Nov 26, 2020
| @@ -229,6 +237,8 @@ namespace AppInstaller::Utility | |||
|
|
|||
| aesThread.join(); | |||
|
|
|||
| AICLI_LOG(Core, Info, << "Finished applying motw using IAttachmentExecute. Result: " << hr); | |||
| AICLI_LOG(Core, Info, << "Finished applying motw using IAttachmentExecute. Result: " << hr << " AES Save result: " << aesSaveResult); | |||
There was a problem hiding this comment.
AES [](start = 104, length = 3)
let's say "Attachment Execution Service" #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Validation
Existing tests. Manual verification by installing several apps succeeded.
Microsoft Reviewers: Open in CodeFlow