Adding export to WinGetUtil.dll to expose Version comparing #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did some perf testing and comparisons against just passing in the entire array of versions to be sorted in from .NET and marshaling the sorted array back out. Surprisingly, it's actually faster to do it this way. Took about 12s to sort 10k versions using this method, and 15s to pass in and sort the entire array. Since this code is also cleaner and simpler, seems like a win-win. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yao-msft
reviewed
Nov 24, 2020
yao-msft
reviewed
Nov 24, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new export, WinGetCompareVersions, which compares two versions for ordering purposes. This allows other tools and services to be guaranteed the same version sorting when working with the OWC that WinGet uses.
Microsoft Reviewers: Open in CodeFlow