Fix registry reading code to allow for a single null byte on a wide string value #662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #657
Change
The issue was due to a REG_SZ value containing a wide string with a narrow null terminator. Move to using RegGetValue, as it ensures that a proper null character will always be at the end of a registry string value.
Validation
The provided registry hive was readable by the underlying list code, and a new test is added to ensure that this specific case works.
Microsoft Reviewers: Open in CodeFlow