Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor schema changes from review comments and for better compatibility #759

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Minor schema changes from review comments and for better compatibility #759

merged 1 commit into from
Feb 19, 2021

Conversation

yao-msft
Copy link
Contributor

@yao-msft yao-msft commented Feb 18, 2021 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@yao-msft yao-msft requested a review from a team as a code owner February 18, 2021 06:19
JohnMcPMS
JohnMcPMS approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with these; did you get sign-off from other via mail/Teams or should they officially weigh in here?

@yao-msft
Copy link
Contributor Author

I'll merge after consensus is reached

@yao-msft yao-msft merged commit dd557b2 into microsoft:master Feb 19, 2021
@yao-msft yao-msft deleted the schemavalidate branch February 19, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yao-msft @JohnMcPMS