Recommend using overrides in error message (#446)

microsoft · Sep 11, 2023 · 1b5759f · 1b5759f
1 parent e4d79b3
commit 1b5759f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/src/WingetCreateCLI/Commands/UpdateCommand.cs b/src/WingetCreateCLI/Commands/UpdateCommand.cs
@@ -356,6 +356,10 @@ public async Task<Manifests> UpdateManifestsAutonomously(Manifests manifests)
                 {
                     Logger.WarnLocalized(nameof(Resources.ArchitectureOverride_Warning));
                 }
+                else
+                {
+                    Logger.WarnLocalized(nameof(Resources.UseOverrides_ErrorMessage));
+                }
 
                 return null;
             }

diff --git a/src/WingetCreateCLI/Properties/Resources.Designer.cs b/src/WingetCreateCLI/Properties/Resources.Designer.cs
diff --git a/src/WingetCreateCLI/Properties/Resources.resx b/src/WingetCreateCLI/Properties/Resources.resx
@@ -607,7 +607,7 @@
     <value>Would you like to modify the optional default locale fields?</value>
   </data>
   <data name="NewInstallerUrlMustMatchExisting_Message" xml:space="preserve">
-    <value>Each new installer URL must have a single match to an existing installer based on installer type and architecture. The following installers failed to match an existing installer:</value>
+    <value>Each new installer URL must have a single match to an existing installer based on architecture, installer type and scope. The following installers failed to match an existing installer:</value>
   </data>
   <data name="DetectedArchMismatch_Message" xml:space="preserve">
     <value>The architecture detected from the binary might be different than what is specified in the installer URL for the following installer(s):</value>
@@ -1099,4 +1099,7 @@
   <data name="VersionManifest_Message" xml:space="preserve">
     <value>Version Manifest:</value>
   </data>
+  <data name="UseOverrides_ErrorMessage" xml:space="preserve">
+    <value>Try using the architecture and/or scope overrides to uniquely match new URLs to existing installer nodes in the manifest.</value>
+  </data>
 </root>