Skip to content

Commit

Permalink
Add VClibs dependency to package manifest (#144)
Browse files Browse the repository at this point in the history
* add vclib package dependency

* add package dependency info to readme

* update dependency info in README
  • Loading branch information
ryfu-msft authored Aug 25, 2021
1 parent 10dc9bd commit 5cf5728
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ Unfortunately, we can't use the msixbundle in a standard Azure Pipeline pool. In

If .NET isn't already installed, you can use https://aka.ms/wingetcreate/latest/self-contained or https://aka.ms/wingetcreate/preview/self-contained, which has .NET built-in, but is a larger download.

> When using either the framework-dependent or self-contained exe, make sure your build machine has the [Microsoft Visual C++ Redistributable for Visual Studio](https://support.microsoft.com/en-us/topic/the-latest-supported-visual-c-downloads-2647da03-1eea-4433-9aff-95f26a218cc0) already installed. Without this, the standalone WingetCreate exe will fail to execute and likely show a "DllNotFoundException" error.
Then simply add a new powershell task to download the exe, and run it to update your manifest. It's recommended to not hardcode your PAT in your script, but instead use a [secret pipeline variable](https://docs.microsoft.com/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#secret-variables)

- powershell: |
Expand Down
1 change: 1 addition & 0 deletions src/WingetCreatePackage/Package.appxmanifest
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

<Dependencies>
<TargetDeviceFamily Name="Windows.Universal" MinVersion="10.0.17763.0" MaxVersionTested="10.0.18362.0" />
<PackageDependency Name="Microsoft.VCLibs.140.00.UWPDesktop" MinVersion="14.0.25426.0" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" />
</Dependencies>

<Resources>
Expand Down

0 comments on commit 5cf5728

Please sign in to comment.