Return false for github submit exceptions (#261)

microsoft · Apr 12, 2022 · 81263e5 · 81263e5
1 parent 764c562
commit 81263e5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/WingetCreateCLI/Commands/BaseCommand.cs b/src/WingetCreateCLI/Commands/BaseCommand.cs
@@ -501,16 +501,16 @@ protected async Task<bool> GitHubSubmitManifests(Manifests manifests)
                 if (e is Octokit.ForbiddenException)
                 {
                     Logger.ErrorLocalized(nameof(Resources.Error_Prefix), e.Message);
-                    return true;
+                    return false;
                 }
                 else if (e is NonFastForwardException nonFastForwardException)
                 {
                     Logger.ErrorLocalized(nameof(Resources.FastForwardUpdateFailed_Message), nonFastForwardException.CommitsAheadBy);
-                    return true;
+                    return false;
                 }
                 else
                 {
-                    return false;
+                    throw;
                 }
             }