Throw parse exception first (#465)

microsoft · Oct 30, 2023 · ba89591 · ba89591
1 parent c9e4eec
commit ba89591
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/WingetCreateCore/Common/PackageParser.cs b/src/WingetCreateCore/Common/PackageParser.cs
@@ -219,15 +219,15 @@ public static void UpdateInstallerNodesAsync(List<InstallerMetadata> installerMe
 
             int numOfNewInstallers = installerMetadataList.Sum(x => x.NewInstallers.Count);
 
-            // We only allow updating manifests with the same package count
-            if (numOfNewInstallers != existingInstallers.Count)
+            if (parseFailedInstallerUrls.Any())
             {
-                throw new InvalidOperationException();
+                throw new ParsePackageException(parseFailedInstallerUrls);
             }
 
-            if (parseFailedInstallerUrls.Any())
+            // We only allow updating manifests with the same package count
+            if (numOfNewInstallers != existingInstallers.Count)
             {
-                throw new ParsePackageException(parseFailedInstallerUrls);
+                throw new InvalidOperationException();
             }
 
             Dictionary<Installer, Installer> installerMatchDict = new Dictionary<Installer, Installer>();