Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear exception after timeout while downloading an installer #197

Closed
VlaDexa opened this issue Oct 29, 2021 · 0 comments · Fixed by #201
Closed

Unclear exception after timeout while downloading an installer #197

VlaDexa opened this issue Oct 29, 2021 · 0 comments · Fixed by #201
Labels
Issue-Bug Resolution-Fix-Committed
Milestone
1.0 Create

Comments

@VlaDexa
Copy link

VlaDexa commented Oct 29, 2021

Description of the new feature / enhancement

The error now just says "Couldn't download an installer" and spits out stack trace.

I think it would be better to explicitly say that timout happened, rather than make user try to read the trace, or add an option to extend the timeout duration.

Now it looks like this:
image

Proposed technical implementation details

No response
@VlaDexa VlaDexa added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 29, 2021
@ghost ghost added the Needs-Triage label Oct 29, 2021
@ryfu-msft ryfu-msft added this to the v1.0-Create milestone Oct 29, 2021
@ryfu-msft ryfu-msft removed the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 4, 2021
@ryfu-msft ryfu-msft mentioned this issue Nov 4, 2021
Merged
@ghost ghost added the In-PR label Nov 4, 2021
@ghost ghost added Resolution-Fix-Committed and removed In-PR labels Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug Resolution-Fix-Committed
Projects
WinGet
Archived in project
Milestone
1.0 Create
Development

Successfully merging a pull request may close this issue.

Handle taskcanceled exception with error message microsoft/winget-create
2 participants
@VlaDexa @ryfu-msft