Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle taskcanceled exception with error message #201

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Handle taskcanceled exception with error message #201

merged 4 commits into from
Nov 4, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Nov 4, 2021 •
edited by ghost
Loading

Fixes #197

Changes

  • Handles the exception that's thrown when the download request fails due to timeout.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner November 4, 2021 18:34
@ghost ghost added the Issue-Bug label Nov 4, 2021
palenshus
palenshus approved these changes Nov 4, 2021
View reviewed changes
src/WingetCreateCLI/Commands/BaseCommand.cs Outdated Show resolved Hide resolved
@ryfu-msft ryfu-msft merged commit 823cb61 into main Nov 4, 2021
@ryfu-msft ryfu-msft deleted the taskCanceledException branch November 4, 2021 19:23
mohmadalabdalui
mohmadalabdalui reviewed Oct 13, 2022
View reviewed changes
Copy link

@mohmadalabdalui mohmadalabdalui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

@mohmadalabdalui mohmadalabdalui mentioned this pull request Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohmadalabdalui mohmadalabdalui mohmadalabdalui left review comments

@palenshus palenshus palenshus approved these changes

Assignees
No one assigned
Labels
Issue-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear exception after timeout while downloading an installer
3 participants
@ryfu-msft @palenshus @mohmadalabdalui