Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass in a PR title with submit and update #359

Closed
edwardskrod opened this issue Apr 13, 2023 · 1 comment
Closed

Add ability to pass in a PR title with submit and update #359

edwardskrod opened this issue Apr 13, 2023 · 1 comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Comments

@edwardskrod
Copy link
Member

edwardskrod commented Apr 13, 2023

Description of the new feature / enhancement

What

Add ability to change the automatically-generated PR title when submitting PR.

Why

When submitting a PR with WinGetCreate update or WinGetCreate submit, the PR titles are automatically generated from the PackageIdentifier and PackageVersion -v
There are times when it would be nice to update the PR title with a custom PR title.

For example, Visual Studio has Preview versions that get released on a regular cadence. Visual Studio 17.6 has 8 Preview Versions.

Preview versions are based on the first release of the minor, i.e. 17.6.0.

Right now, each preview version's PR in GitHub is identical:

Microsoft.VisualStudio.2022.Community.Preview version 17.6.0

Instead, Visual Studio would like to be able to add the Preview version to the title.

  • Microsoft.VisualStudio.2022.Community.Preview version 17.6.0 Preview 1
  • Microsoft.VisualStudio.2022.Community.Preview version 17.6.0 Preview 2
  • Microsoft.VisualStudio.2022.Community.Preview version 17.6.0 Preview 3

To do this today, we'd need to update the version from "17.6.0" to "17.6.0 Preview 1". But this would also update the package version in the manifest, which is something we don't want to do.

Instead, we propose to allow WinGetCreate to accept a parameter to override the PR title.

Proposed technical implementation details

wingetcreate.exe submit [<options>] [-p <pr title>]
wingetcreate.exe update <id> [-u <urls>] [-v <version>] [-s] [-t <token>] [-o <output directory>] [-p <pr title>]

Accept the PR title as a command line parameter for the submit and update commands. Use this title rather than automagically generating the title in code from the Id and Version..

@edwardskrod edwardskrod added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 13, 2023
@ryfu-msft
Copy link
Contributor

Fixed in PR #362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

No branches or pull requests

3 participants