-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arg for changing pull request title #362
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you have is perfectly fine. Ideally, we would want to show a warning message to the user that --submit is needed in combination with --prtitle, but I think the user will ultimately figure that out when they realize that no PR was submitted. I agree with you that this is a pretty harmless/trivial scenario. Everything else looks good :)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Oopsies, found an unwanted change I mistakenly made in |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of the changes
prTitle
to BaseCommand.GitHubSubmitManifests and avoid breaking existing calls of this function.ApiValidationException
. The current limit seems to be 1024 characters (albeit the error response message says 256 chars)<PackageId> version <PackageVersion>
will be used.ArgumentException
Need feedback
Since
--prtitle
forupdate
command is only applicable when the--submit
flag is used, then what if a user was to use --prtitle in the update command without setting the submit flag?I looked at getting a native solution from CommandLineParser to handle this option dependency on another option, but couldn't find the capability in the module to do so. Related issue: commandlineparser/commandline#3
The alternative would be to handle it manually in the code and print a localized warning message something like "Submit flag is not set. The value of title is ignored.", but since this seems like a harmless scenario I decided not to handle it. Please let me know if I am thinking wrong about any of this.
Microsoft Reviewers: Open in CodeFlow