Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify telemetry first run experience to be non-blocking #117

Merged
merged 5 commits into from
Aug 12, 2021
Merged

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Jul 21, 2021

The first run experience waits for the user the provide their consent, which causes an issue for usage in a CI/CD scenario by creating a blocking event. To resolve this issue, we instead notify users of the default telemetry settings, but provide instructions as to how to turn them off.

Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner July 21, 2021 16:46
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost added the Needs-Author-Feedback label Aug 6, 2021
@ghost ghost removed the Needs-Author-Feedback label Aug 6, 2021
@ryfu-msft ryfu-msft enabled auto-merge (squash) August 12, 2021 17:48
@ryfu-msft ryfu-msft merged commit d4260f5 into main Aug 12, 2021
@ryfu-msft ryfu-msft deleted the firstRun branch August 12, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants