New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format exception bug when package parsing fails #156

Merged

ryfu-msft merged 1 commit into main from FormatException

Sep 2, 2021

Contributor

ryfu-msft commented Sep 2, 2021 •

edited by ghost

Loading

Fixes #147

This PR adds the following changes:

Refactors the ParsePackages method in the NewCommand so that it is void and throws an exception if parsing fails.
Ensure that the failed installer URL is provided to the formatted string when error logging.

Microsoft Reviewers: Open in CodeFlow


          fix format exception bug

c93f1b5

ryfu-msft requested a review from arjun-msft

September 2, 2021 21:35

ryfu-msft requested a review from a team as a code owner

September 2, 2021 21:35

ghost added the Issue-Bug label

arjun-msft approved these changes

View reviewed changes

ryfu-msft merged commit 371490a into main

ryfu-msft deleted the FormatException branch

September 2, 2021 21:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels