Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index prefix to installer menu item #169

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Add index prefix to installer menu item #169

merged 2 commits into from
Sep 15, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Sep 15, 2021 •
edited by ghost
Loading

Changes:

  • Prepends "INSTALLER {index}: " to each installer node in order to make them unique. This fixes a bug that occurs when a user uses the new command to create a new manifest with 2 identical installer URLs
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner September 15, 2021 19:09
palenshus
palenshus approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft ryfu-msft merged commit f4af949 into main Sep 15, 2021
@ryfu-msft ryfu-msft deleted the sameInstallerBug branch September 15, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palenshus palenshus palenshus approved these changes

Assignees
No one assigned
Labels
Issue-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryfu-msft @palenshus