Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UpdateCommand support for 1.1 Schema #224

Merged
merged 5 commits into from
Feb 10, 2022
Merged

Add UpdateCommand support for 1.1 Schema #224

merged 5 commits into from
Feb 10, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Feb 9, 2022 •
edited by ghost
Loading

Resolves #139

Changes:

  • Increment version from 0.4.4 to 0.5 in preparation for new release
  • Adds a custom AliasTypeInspector that prioritizes properties with the YamlMemberAttribute to handle custom properties overrides such ReleaseDate and Agreement.
  • Updates the Automapper to include mapping for for newly added object models (i.e. AppsAndFeaturesEntry, ExpectedReturnCode, PackageDependencies, Markets, etc.)
  • Ensures UpdateCommand updates ManifestVersion field to the latest schema version.

Verification:
Added 3 unit tests to cover the above changes

  • UpdatesToLatestManifestVersion()
  • UpdateDeserializesAliasDefinedFields()
  • UpdateFullSingletonVersion1_1()
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner February 9, 2022 20:39
@ghost ghost added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 9, 2022
@ryfu-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yao-msft
yao-msft approved these changes Feb 10, 2022
View reviewed changes
Copy link

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft ryfu-msft enabled auto-merge (squash) February 10, 2022 06:58
@ryfu-msft ryfu-msft merged commit c0d9ac0 into microsoft:main Feb 10, 2022
@ryfu-msft ryfu-msft deleted the FixUpdateCommand branch May 27, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denelon denelon denelon left review comments

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Windows Package Manager v1.1 schema
3 participants
@ryfu-msft @yao-msft @denelon