-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement scope override and scope detection from installer URL #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ArchitectureOverride_Warning
Resource string may also need to be updated. An updated message may be something like:
If the installer you provided fails to match an existing installer even when overriding the architecture, you may need to
override the scope
or edit the existing manifest manually. Make sure that the existing manifest has a single installer that matches the overriding architecture,scope
and installer type of the new installer. To modify an existing manifest, use the '--interactive' flag with the update command and submit the new changes. Once the changes are published, please try again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no way for winget-create to detect the scope of an installer. This PR adds the override functionality to allow users to specify the intended scope of the installer to improve matching performance during updates.
Changes:
|user
or|scope
to the installer URL to specify the scope they want.Tests:
Microsoft Reviewers: Open in CodeFlow