fix: Make sure the enumerable is a List #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to setup the `Tags` field which is a List<T>. IEnumerable<T> of the SelectListIterator does not convert to a List<T>. An IEnumerable<T> of List<T> does.
sandercox
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Jun 23, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to setup the
Tagsfield which is a List. IEnumerable of the SelectListIterator does not convert to a List. An IEnumerable of List does.After PR#373 the code was introduced to Trim installer URLs, and trim these properties.
Apparently this works for these URLs that get set to a property of
IEnumerable<string>but when trying to set the Tags when setting optional default locale fields, this threw an Exception:Apparently an
IEnumerable<string>can be set to aList<string>when the enumerable comes from an actualList<string>but not from a Linq based List.Turning the Trimmed list back into a real List (it originates from
Prompt.List()) it seems to work for both URLs and the Tags.Microsoft Reviewers: codeflow:open?pullrequest=#390