Improvements to replace argument #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
microsoft-github-policy-service
bot
added
the
Issue-Feature
ryfu-msft
requested changes
Nov 28, 2023
ryfu-msft
requested changes
Nov 30, 2023
src/WingetCreateTests/WingetCreateTests/UnitTests/UpdateCommandTests.cs
Outdated
Show resolved
Hide resolved
src/WingetCreateTests/WingetCreateTests/UnitTests/UpdateCommandTests.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submit#478Changes
Added support for
--replacefor submit command.To avoid confusion, I've updated the behavior of update command to fail if submission arguments are not provided with
--submit.Since there isn't good support from the parser library for handling option dependency (ref commandlineparser/commandline#3), I had to handle this manually (i think it's okay since this is only applicable for update command and there could only ever be a handful of arguments that have dependency on --submit).
Now we can decide if we want this to be a "warning" behavior or a "blocking" behavior. I decided to go with a blocking behavior since users are likely to cancel the running update command or run submit command with --replace afterwards if they actually meant to use the replace behavior. Having it fail early makes user quickly recognize mistake and re-run the command with or without --replace.
Microsoft Reviewers: Open in CodeFlow