Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Package Issue]: Git.Git - enable Terminal integration #109915

Closed
2 tasks done
mwisnicki opened this issue Jun 15, 2023 · 2 comments · Fixed by #110011
Closed
2 tasks done

[Package Issue]: Git.Git - enable Terminal integration #109915

mwisnicki opened this issue Jun 15, 2023 · 2 comments · Fixed by #110011
Labels
Help-Wanted This is a good candidate work item from the community. Issue-Bug It either shouldn't be doing this or needs an investigation. Package-Update This package needs to be updated
Milestone
1.7 Packages

Comments

@mwisnicki
Copy link

mwisnicki commented Jun 15, 2023 •
edited
Loading

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

Windows Terminal no longer autodetects Git Bash and now expects Git to register itself (which is safe to do even if Terminal is not installed): microsoft/terminal#15559

Unfortunately the installer option is off by default and upstream will not change it: git-for-windows/git#4468

Can you add /enable-component windowsterminal to install flags?
Not sure if that's the right syntax but that's how the option is named in https://github.com/git-for-windows/build-extra/blob/main/installer/install.iss#L115

Steps to reproduce

winget install -e --id Microsoft.WindowsTerminal
winget install -e --id Git.Git
wt

Actual behavior

No git bash profile

Expected behavior

Git Bash profile is on the list

Environment

-

Screenshots and Logs

No response
@mwisnicki mwisnicki added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jun 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jun 15, 2023
@stephengillie stephengillie added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Jun 16, 2023
@BrandonWanHuanSheng
Copy link
Contributor

It look like Windows 10 may be failed due to there is no Windows Terminal installed but Windows 11 have Windows Terminal might be success. Because that Windows 11 Setup have come with Windows Terminal.

@BrandonWanHuanSheng BrandonWanHuanSheng mentioned this issue Jun 17, 2023
Merged
6 tasks
@quhxl
Copy link
Contributor

quhxl commented Jun 17, 2023

#110011 (comment)

derrickstolee added a commit to derrickstolee/winget-pkgs that referenced this issue Aug 9, 2023
@derrickstolee
microsoft/git: add custom installer arguments
47fdf43 
These arguments are intended to tell the installer to be as quiet as
possible.

* /SUPPRESSMSGBOXES indicates that the installer should not create
  pop-up windows when an issue arises. Instead, the installer will fail.
  This will resolve microsoft/git#595.

* "/enable-component windowsterminal" was added to the Git/Git manifest
  in microsoft#110011 to resolve microsoft#109915, which was creating some installation
  problems on Windows 10.

Signed-off-by: Derrick Stolee <[email protected]>
microsoft-github-policy-service bot pushed a commit that referenced this issue Aug 10, 2023
@derrickstolee
Microsoft git installer options (#116034)
d829428 
* microsoft/git: add custom installer arguments

These arguments are intended to tell the installer to be as quiet as
possible.

* /SUPPRESSMSGBOXES indicates that the installer should not create
  pop-up windows when an issue arises. Instead, the installer will fail.
  This will resolve microsoft/git#595.

* "/enable-component windowsterminal" was added to the Git/Git manifest
  in #110011 to resolve #109915, which was creating some installation
  problems on Windows 10.

Signed-off-by: Derrick Stolee <[email protected]>

* microsoft/git: match some format for Git/Git's manifest

The Git/Git manifest has some additional options that were created
directly by the Winget team, as opposed to microsoft/git which was
created by the Git team. Since the Winget team is likely better at this
sort of thing, adopt some of the choices made over there.

These are mostly innocuous, though there is one interesting difference
that still remains: the Git/Git manifest has two installers with
different 'Scope' values ('machine' and 'user') while microsoft/git is
only available via 'machine' scope. This is purposefully left alone
since there is no difference in how the installers are specified and we
are not sure we want to support user-only installs of microsoft/git.

Signed-off-by: Derrick Stolee <[email protected]>

---------

Signed-off-by: Derrick Stolee <[email protected]>
@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
@JohnstonJ JohnstonJ mentioned this issue Sep 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help-Wanted This is a good candidate work item from the community. Issue-Bug It either shouldn't be doing this or needs an investigation. Package-Update This package needs to be updated
Projects
None yet
Milestone
1.7 Packages
Development

Successfully merging a pull request may close this issue.

Registering Git Profile for Windows Terminal on Git.Git manifests BrandonWanHuanSheng/winget-pkgs
5 participants
@mwisnicki @denelon @quhxl @stephengillie @BrandonWanHuanSheng