-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Package Issue]: yt-dlp.yt-dlp hard depends on Gyan.FFmpeg and no ability to use shared ffmeg #138665
Comments
Hi I'm an AI powered bot that finds similar issues based off the issue title. Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you! Closed similar issues:
|
I believe this depends on: |
I believe the other problem (and why I didn't include ffmpeg as a dependency in my yt-dlp PRs) is that ffmepg isn't required for the operation of yt-dl, it's needed when remuxing or converting audio/video tracks, in which case the program informs the user that ffmpeg is needed. Would it not be best left to user choice on their installation method of this optional tool, especially given a user may already have ffmpeg available in path via an alternative means (choco for example places it in a directory within If it makes sense, I think we just keep ffmpeg out of the yt-dlp installer.yamls as a dependency. Also, yt-dl also recommends having PhantomJS installed in some instances, yet we don't throw that in by default 😅 |
If some form of
This is the goal behind the Issue that mdanish-kh linked.
The error I mentioned above might block pipeline validation approval, or result in a poor user experience for users who don't have
Maybe we should. It's not in the repo yet, but appears to be a |
installing Gyan.FFmpeg.Shared doesn't even properly add ffmpeg to my PATH in my case Gyan.FFmpeg fixes this tho |
Please confirm these before moving forward
Category of the issue
Other
Brief description of your issue
yt-dlp.yt-dlp
hard depends onGyan.FFmpeg
, but there's alsoGyan.FFmpeg.Shared
, who want/need the libraries provided by ffmpeg, so having 2 packages that provide the same thing isn't really ideal.Steps to reproduce
winget install yt-dlp
Actual behavior
it installs
Gyan.FFmpeg
, even if i already haveGyan.FFmpeg.Shared
installedExpected behavior
either the ability to choose which ffmpeg package to install or having a separate package called yt-dlp (shared)
Environment
Screenshots and Logs
No response
The text was updated successfully, but these errors were encountered: