-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Rizin.Cutter in version 2.2.1 #109817
New package: Rizin.Cutter in version 2.2.1 #109817
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@microsoft-github-policy-service agree |
@wingetbot waivers Add Validation-Executable-Error |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
assarbad, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
Hello assarbad, Template: msftbot/validationCompleted |
@stephengillie / @denelon - I'm not sure the Validation-Executable-Error should have been waived here. Although it may install and run fine on Windows 11, on Windows 10 machines it has a dependency on MSVCP140 and VCRUNTIME140_1 and VCRUNTIME140 - that is to say, has a dependency on |
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
@Trenly We validate on Windows 11 by default unless the minimum OS version specifies Windows 10 if I'm not mistaken. |
And I'm suggesting it should be the other way around - validation should be run on Windows 10 unless the minimum OS specifies Windows 11 |
Let me confirm with the team. |
Confirmed with @denelon the Pipelines run Win10 by default and Win11 only if specified - It's possible that manual validation uses Win11 instead of Win10 |
Sorry for the delay. I was offline for some mandatory in person training. I was wrong. We default to a Windows 10 VM during validation unless the manifest states a requirement for Windows 11. It appears not all users who were performing manual validation were also defaulting to a Windows 10 VM. This will be communicated to the team today and added to our process documentation. |
Thanks for the quick follow up! |
Could you explain in brief how this affects future contributions? Is there a way to express the dependency on Thanks anyway for pointing it out! |
We don't yet have support for dependencies as a stable feature. We're still looking at a few challenges related to reboots that can get triggered by dependencies being upgraded. Yes, the dependency can be identified in the manifest, but we're holding off on accepting packages that fail during install if the dependency isn't present. |
Shame, but thanks so much for the clarification! |
I've got it in the 1.6 milestone so we're aiming for September. |
@assarbad @Trenly you might be interested in #115801 BTW, if something is needed from our side - please let us know by opening an issue at https://github.com/rizinorg/cutter/issues |
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.xref: rizinorg/cutter#3056
Microsoft Reviewers: codeflow:open?pullrequest=#109817