Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KDEConnect, Kate and Okular #2367

Closed
wants to merge 1 commit into from

Conversation

mimi89999
Copy link
Contributor

@mimi89999 mimi89999 commented Jul 8, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

KDE's binary-factory only keeps last 10 build artifacts and builds are daily. A manifest would work for max 10 days. Unless

I don't see how those apps can stay in the repo. I also missed that when adding Okular to just-install and had to remove it later (just-install/registry#204).

I hope that upstream will provide stable download URLs.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Jul 8, 2020

CLA assistant check
All CLA requirements met.

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Jul 8, 2020
@ghost
Copy link

ghost commented Jul 8, 2020

mimi89999 The package manager bot determined there was an issue with the pull request. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname.
For details on the error, see the details link below in the build pipeline.

@mimi89999
Copy link
Contributor Author

I will split this in 4 PRs.

@KevinLaMS
Copy link
Contributor

@mimi89999 can we close this PR?

@mimi89999
Copy link
Contributor Author

Yes. I'm closing it.

@mimi89999 mimi89999 closed this Jul 23, 2020
@mimi89999 mimi89999 deleted the binary-factory branch July 23, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PullRequest-Error PR is Invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants