Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WinGet #332

Closed
wants to merge 3 commits into from
Closed

Add WinGet #332

wants to merge 3 commits into from

Conversation

NatoBoram
Copy link

@NatoBoram NatoBoram commented May 19, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Any good package manager must at least be able to install itself ;)

cc ScoopInstaller/Extras#4107 microsoft/winget-cli#505 #825 #19425

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 19, 2020
@ghost ghost assigned KevinLaMS May 19, 2020
@ghost
Copy link

ghost commented May 19, 2020

This submission has moved to manual review.

jos3s
jos3s previously approved these changes May 21, 2020
Copy link
Contributor

@jos3s jos3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid manifest

@qiancy98 qiancy98 mentioned this pull request Jun 29, 2020
@denelon
Copy link
Contributor

denelon commented Jun 30, 2020

Unfortunately, this suffers from lack of dependencies. We're working on a solution for VCLibs also related to the Sandbox PowerShell script #827 .

@NatoBoram
Copy link
Author

Couldn't those problems just be solved afterwards? After all, one might already have the necessary dependencies, otherwise an error message can be equally helpful, and it's normal for a fairly new installer-executor to not have dependency awareness at first. And now that I think about it, anyone trying to install WinGet via WinGet probably have most dependencies already.

@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 18, 2020
@KevinLaMS
Copy link
Contributor

Deployment wants to shut down old winget to deploy new winget, deployment sends the old winget a ctrl-c signal, the old winget cancels all it’s doing(including the ongoing “install new winget”).

@ghost ghost removed the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 29, 2020
@KevinLaMS KevinLaMS mentioned this pull request Dec 23, 2020
4 tasks
@denelon denelon added the Blocking-Issue Manifest validation is blocked by a known issue. label Feb 4, 2021
@denelon
Copy link
Contributor

denelon commented May 4, 2021

microsoft/winget-cli#505

@ghost ghost removed the Blocking-Issue Manifest validation is blocked by a known issue. label Jun 30, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 30, 2021
@ghost
Copy link

ghost commented Jun 30, 2021

Hello @NatoBoram,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 30, 2021
@ghost ghost added Needs: Attention and removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Jun 30, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Needs: Attention label Jun 30, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NatoBoram
Copy link
Author

Unfortunately, this suffers from lack of dependencies. We're working on a solution for VCLibs also related to the Sandbox PowerShell script #827.

Hold on a second, I remember installing from github.com/microsoft/winget-cli/releases on brand new instances of Windows 10 like last week without missing any dependencies. Are the dependencies in newer builds of Windows?

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jun 30, 2021
@ghost
Copy link

ghost commented Jun 30, 2021

Hello @NatoBoram,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jun 30, 2021
@denelon
Copy link
Contributor

denelon commented Jun 30, 2021

I think we're still blocked on the fact that the install cancels our active installation. We're looking at a delayed registration via MSIX which would unblock this one. I hope we get to that soon 😊

@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 1, 2021
@ItzLevvie
Copy link
Contributor

cc @denelon: could you please add the "Blocking-Issue" label on this PR?

@denelon denelon added the Blocking-Issue Manifest validation is blocked by a known issue. label Aug 18, 2021
@denelon
Copy link
Contributor

denelon commented Feb 12, 2022

Just an "FYI" here. It's now possible to winget install "App Installer" with the connectivity to the "msstore" source. One of the things the Microsoft Store does is handle some of the dependencies related to MSIX packages in the store. We've been talking about the fact that the Windows Package Manager dependencies "must" have been available in order to run winget upgrade winget in the first place. The bigger challenge here is that the package is actually the "App Installer" package. We could use winget as the moniker though.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 13, 2022
@ItzLevvie
Copy link
Contributor

Close with reason: Replaced by PR 56841;

@NatoBoram
Copy link
Author

Here's a link to it for mobile users:

@NatoBoram NatoBoram deleted the winget branch February 17, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants