Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenJDK 11 for AdoptOpenJDK #408

Merged
7 commits merged into from
May 20, 2020
Merged

OpenJDK 11 for AdoptOpenJDK #408

7 commits merged into from
May 20, 2020

Conversation

brunoborges
Copy link
Member

@brunoborges brunoborges commented May 20, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 20, 2020
@ghost ghost assigned KevinLaMS May 20, 2020
@ghost
Copy link

ghost commented May 20, 2020

This submission has moved to manual review.

karianna
karianna suggested changes May 20, 2020
View reviewed changes
manifests/AdoptOpenJDK/OpenJDK/11.0.7.yaml
Description: Community-driven, Vendor-neutral build of OpenJDK for Windows x64.
Installers:
- Arch: x64
Url: https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.7%2B10.2/OpenJDK11U-jdk_x64_windows_hotspot_11.0.7_10.msi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend using the Adopt API over the direct connection to GitHub which is rate limited

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do a get an MSI installer with the API?

https://api.adoptopenjdk.net/swagger-ui/#/Binary/get_v3_binary_version__release_name___os___arch___image_type___jvm_impl___heap_size___vendor_

Copy link
Contributor

@WtfJoke WtfJoke May 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly Adopt API doesnt provide an endpoint for the installer (msi) and only for the binary (zip).

Latest jdk 11 binary (.zip) could be retreived with following api call:
https://api.adoptopenjdk.net/v3/binary/version/jdk-11.0.7%2B10.2/windows/x64/jdk/hotspot/normal/adoptopenjdk?project=jdk

And winget doesnt seem to support installs of .zip yet, see #174

So I dont know if the author of this pr can solve the situation.

EDIT: You should always refresh the page before you write a comment 😅

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label May 20, 2020
@ghost
Copy link

ghost commented May 20, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes May 20, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 1dd589e into microsoft:master May 20, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WtfJoke WtfJoke WtfJoke left review comments

@karianna karianna karianna requested changes

Assignees

@KevinLaMS KevinLaMS

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brunoborges @wingetbot @karianna @WtfJoke @KevinLaMS