-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenJDK 11 for AdoptOpenJDK #408
Conversation
Fix URL to point to OpenJDK binary.
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
This submission has moved to manual review. |
Description: Community-driven, Vendor-neutral build of OpenJDK for Windows x64. | ||
Installers: | ||
- Arch: x64 | ||
Url: https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.7%2B10.2/OpenJDK11U-jdk_x64_windows_hotspot_11.0.7_10.msi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend using the Adopt API over the direct connection to GitHub which is rate limited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do a get an MSI installer with the API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly Adopt API doesnt provide an endpoint for the installer (msi) and only for the binary (zip).
Latest jdk 11 binary (.zip) could be retreived with following api call:
https://api.adoptopenjdk.net/v3/binary/version/jdk-11.0.7%2B10.2/windows/x64/jdk/hotspot/normal/adoptopenjdk?project=jdk
And winget doesnt seem to support installs of .zip yet, see #174
So I dont know if the author of this pr can solve the situation.
EDIT: You should always refresh the page before you write a comment 😅
Hello @KevinLaMS! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation has completed
Microsoft Reviewers: Open in CodeFlow