Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Machine Scope for Eloston.Ungoogled-Chromium #69382

Merged
1 commit merged into from
Aug 11, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Aug 11, 2022

@Nifury - I checked the version before this and it did contain scopes for user and machine. If possible, when updating this package in the future, be sure to keep both the user scope and machine scope as it causes issues for people upgrading if both are not present in new versions. (Ref #68863)

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 11, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 11, 2022

Trenly,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 11, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

Hello Trenly,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit 0b5b5a1 into microsoft:master Aug 11, 2022
@Nifury
Copy link
Contributor

Nifury commented Aug 11, 2022

Oh sorry I didn't know the machine scope was actually requested by a user. I removed it only because winget-create doesn't support multiple scopes for the same installer. I'll try other ways to update this package automatically.

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Trenly
Copy link
Contributor Author

Trenly commented Aug 11, 2022

@denelon - Do you know if there are any open issues over at create regarding same scope for multiple installers?

@Trenly Trenly deleted the ElostonMachineLevel branch August 11, 2022 23:34
@Nifury
Copy link
Contributor

Nifury commented Aug 11, 2022

Ah this issue occurs when I update the manifest. microsoft/winget-create#291 (comment)

@Trenly
Copy link
Contributor Author

Trenly commented Aug 11, 2022

Ohhh, I see. Makes sense! Thanks for your help looking into it!!

@denelon
Copy link
Contributor

denelon commented Aug 12, 2022

@ryfu-msft can you check wingetcreate for this scenario?

@ryfu-msft
Copy link
Contributor

This is currently a scenario that is not supported by wingetcreate. I will work on getting this fixed as multiple users have brought up this issue recently.

As a workaround for now, you can use the --interactive (-i) flag to manually update installers.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Add per-machine installer for Eloston Ungoogled-Chromium (Regression)
6 participants