-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Machine Scope for Eloston.Ungoogled-Chromium #69382
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @wingetbot! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Trenly, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
Hello Trenly, Template: msftbot/validationCompleted |
Oh sorry I didn't know the machine scope was actually requested by a user. I removed it only because winget-create doesn't support multiple scopes for the same installer. I'll try other ways to update this package automatically. |
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
@denelon - Do you know if there are any open issues over at create regarding same scope for multiple installers? |
Ah this issue occurs when I update the manifest. microsoft/winget-create#291 (comment) |
Ohhh, I see. Makes sense! Thanks for your help looking into it!! |
@ryfu-msft can you check wingetcreate for this scenario? |
This is currently a scenario that is not supported by wingetcreate. I will work on getting this fixed as multiple users have brought up this issue recently. As a workaround for now, you can use the --interactive (-i) flag to manually update installers. |
@Nifury - I checked the version before this and it did contain scopes for user and machine. If possible, when updating this package in the future, be sure to keep both the user scope and machine scope as it causes issues for people upgrading if both are not present in new versions. (Ref #68863)
Microsoft Reviewers: Open in CodeFlow