Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zip][WiX] New package: Mobatek.MobaXterm version 23.0.0.5042 #87332

Conversation

SpecterShell
Copy link
Contributor

@SpecterShell SpecterShell commented Nov 3, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SpecterShell SpecterShell changed the title New package: Mobatek.MobaXterm version 22.1.0.4888 [Zip][WIX] New package: Mobatek.MobaXterm version 22.1.0.4888 Nov 3, 2022
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 3, 2022
@ghost
Copy link

ghost commented Nov 3, 2022

Hello @SpecterShell,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 3, 2022
@SpecterShell SpecterShell changed the title [Zip][WIX] New package: Mobatek.MobaXterm version 22.1.0.4888 [Zip][WiX] New package: Mobatek.MobaXterm version 22.1.0.4888 Nov 3, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Nov 3, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 3, 2022
@ghost
Copy link

ghost commented Nov 3, 2022

Hello @SpecterShell,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 3, 2022
@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. .zip labels Nov 3, 2022
@ghost
Copy link

ghost commented Nov 3, 2022

Hello @SpecterShell,

This package appears to reference a compressed .zip archive rather than an installer.

This PR is blocked until support for .zip is implemented in:

Template: msftbot/blockingIssue/zipInstaller

ItzLevvie
ItzLevvie previously approved these changes Nov 8, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 8, 2022
@bet4it
Copy link

bet4it commented Jan 27, 2023

Could it be merged now?

@SpecterShell
Copy link
Contributor Author

#87300

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 28, 2023
@SpecterShell SpecterShell reopened this Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 10, 2023
@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Needs-Author-Feedback This needs a response from the author. labels Feb 15, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 15, 2023
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Feb 15, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @wingetbot,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 16, 2023
@Macleykun
Copy link
Contributor

Can this PR be merged now with the approvals?

@Trenly
Copy link
Contributor

Trenly commented Feb 16, 2023

Can this PR be merged now with the approvals?

Not until it has a successful pipelines run or is manually validated by Microsoft

@adripo
Copy link
Contributor

adripo commented Feb 27, 2023

I created and tested a working alternative package for this application here:
#97869

Please consider fixing this PR or accepting my version. Thank you

@Trenly
Copy link
Contributor

Trenly commented Feb 27, 2023

I created and tested a working alternative package for this application here: #97869

Please consider fixing this PR or accepting my version. Thank you

The referenced PR has the same issue, and the manifest in this PR is both complete and accurate. This application cannot be added until the pipelines are updated or a manual review by Microsoft occurs.

@stephengillie stephengillie self-assigned this Feb 28, 2023
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Installation-Error Error installing application Needs-Author-Feedback This needs a response from the author. labels Feb 28, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello stephengillie,
Validation has completed.

Template: msftbot/validationCompleted

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit d5a5fee into microsoft:master Feb 28, 2023
@stephengillie
Copy link
Collaborator

I created and tested a working alternative package for this application here: #97869
Please consider fixing this PR or accepting my version. Thank you

The referenced PR has the same issue, and the manifest in this PR is both complete and accurate. This application cannot be added until the pipelines are updated or a manual review by Microsoft occurs.

Sorry to miss this for so long. Feel free to @ me for a manual review in the future.

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@SpecterShell SpecterShell deleted the Mobatek.MobaXterm-22.1.0.4888-Newpackage branch March 2, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: mobaxterm Mobatek.MobaXterm
10 participants