Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: LinusDierheimer.fastfetch version 1.9.1 #94697

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jan 26, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

Hello @sitiom,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.4 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@sitiom
Copy link
Contributor Author

sitiom commented Jan 26, 2023

Manifest 1.4

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 26, 2023
@stephengillie stephengillie self-assigned this Jan 26, 2023
@stephengillie stephengillie added Blocking-Issue Manifest validation is blocked by a known issue. .zip labels Jan 26, 2023
@stephengillie stephengillie removed their assignment Jan 26, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 28, 2023

@sitiom sitiom marked this pull request as draft January 28, 2023 01:15
@Trenly
Copy link
Contributor

Trenly commented Feb 9, 2023

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 9, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 9, 2023
@microsoft-github-policy-service
Copy link
Contributor

wingetbot,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@denelon
Copy link
Contributor

denelon commented Feb 23, 2023

@sitom I think this can be converted to a "real PR".

@denelon denelon removed the .zip label Feb 23, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Feb 23, 2023

There are issues such as #94697 (comment), though. I wouldn't like to merge a half-working program.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 3, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello sitiom,
Validation has completed.

Template: msftbot/validationCompleted

@stephengillie
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jan 5, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 5, 2024
@CarterLi
Copy link

Hello, I have received some requests to make fastfetch available in winget. I hope this PR can be made further. A few comments:

  1. This issue is no longer an issue because we embedded the the necessary library in fastfetch. Terminal font should work out of box.
  2. The fastfetch version should be updated. The latest version is v2.13.1.
  3. The PackageIdentifier and URLs should be updated. Fastfetch has been moved to Group fastfetch-cli and the Windows port of fastfetch was fully written by me @CarterLi.

@niu541412
Copy link
Contributor

niu541412 commented May 23, 2024

Hello, I have received some requests to make fastfetch available in winget. I hope this PR can be made further. A few comments:

  1. This issue is no longer an issue because we embedded the the necessary library in fastfetch. Terminal font should work out of box.
  2. The fastfetch version should be updated. The latest version is v2.13.1.
  3. The PackageIdentifier and URLs should be updated. Fastfetch has been moved to Group fastfetch-cli and the Windows port of fastfetch was fully written by me @CarterLi.

Have released in wInget-pkgs with updated info, see #154718 @CarterLi

@sitiom
Copy link
Contributor Author

sitiom commented May 23, 2024

Have released in wInget-pkgs with updated info, see #154718 @CarterLi

Hi, thanks for the update. I have opened up a PR for Winget Releaser upstream (fastfetch-cli/fastfetch#975, @CarterLi please take a look).

@sitiom sitiom closed this May 23, 2024
@sitiom sitiom deleted the LinusDierheimer.fastfetch-1.9.1-1EA3C7CE758B90 branch May 23, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants