Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSLGd: load keymap settings from .wslgconfig into weston.ini #1046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fargiolas
Copy link

Allow user to customize weston settings by providing a .weston.ini file in User Profile directory.

The idea is to give advanced users an easy way to configure a keymap to fallback to if weston rdp backend logic fails to find a mapping between current keyboard layout and XKB ones. See microsoft/weston-mirror#144 for further details.

@hideyukn88
Copy link
Member

Hi. we don't want to expose weston.ini directly from Windows side, this is why we have exposed only certain configuration via .wslgconfig. If the configuration of default keyboard is necessary, please expose it via .wslgconfig, thanks!

Introduce a new "weston-keyboard" section in .wslgconfig where you can
configure weston/xkb keymap settings that will be used as a fallback if
no xkb mapping can be found for current keyboard layout.

Syntax is the same of weston.ini(5). Only keymap related key-value
pairs are imported into WSLG system weston.ini, anything else is
ignored.
@fargiolas
Copy link
Author

@hideyukn88 see the new commit, it should address your concerns.

The idea is to add a new [weston-keyboard] (or whichever name you like) section in .wslgconfig where you can configure keymap settings that will be merged into wslg weston.ini when WSLGd starts and used as a fallback when keyboard layout mapping fails.

This way only keymap related settings are merged into weston.ini instead of exposing the full config file to the user.

This obviously depends on microsoft/weston-mirror#144 being merged as at the moment "us" layout is hardcoded in the rdp backend if layout mapping fails.

@fargiolas fargiolas changed the title WSLGd: load user weston.ini WSLGd: load keymap settings from .wslgconfig into weston.ini Apr 30, 2023
@fargiolas
Copy link
Author

@hideyukn88 any feedback on the latest proposed changes? now that the other PR has been merged (thanks!) it would definitely make life easier for us custom layout users

@hideyukn88
Copy link
Member

@fargiolas, currently we are evaluating the idea to have /etc/wslg.conf, similar to WSL's /etc/wsl.conf, inside user-distro filesystem, so we could do this utilizing that, so please hold on, thanks!

@fargiolas
Copy link
Author

@fargiolas, currently we are evaluating the idea to have /etc/wslg.conf, similar to WSL's /etc/wsl.conf, inside user-distro filesystem, so we could do this utilizing that, so please hold on, thanks!

That would be great! Thanks for the update!

@cassiocsantana
Copy link

I'm looking forward to this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants