Add caching to CI workflow #109
Conversation
naegelejd
force-pushed
the
naegelejd/ci-caching
branch
from
3a6245e
to
d5b64f4
Compare
|
This shaves off 2 minutes (20% of previous CI wall time) for each CI run. |
| key: | ||
| conda-${{ runner.os }}--${{ runner.arch }}--${{ | ||
| hashFiles('ci-environment.yml') }}-${{ | ||
| env.DATE }}-${{ |
There was a problem hiding this comment.
Why do we want the date to be in the cache key?
There was a problem hiding this comment.
Adding the date ensure the cache is updated daily to account for any changes in conda package versions. See https://github.com/marketplace/actions/setup-miniconda#caching-environments, which I essentially copied here.
| with: | ||
| miniforge-variant: Mambaforge | ||
| miniforge-version: latest | ||
| # Do not specify environment file - see Cache step below |
There was a problem hiding this comment.
So at this point, we have an empty environment?
There was a problem hiding this comment.
Yes, the env always be updated in the last step, whether the cache exists or not.
| path: ${{ env.CONDA }}/envs | ||
| key: | ||
| conda-${{ runner.os }}--${{ runner.arch }}--${{ | ||
| hashFiles('ci-environment.yml') }}-${{ |
There was a problem hiding this comment.
Do we want to throw the conda version in there too?
There was a problem hiding this comment.
I don't think it's necessary. The cache is invalidated every 24 hours, so within that time period, if the conda version changes and somehow the resolved set of packages for our ci-environment.yml changes we can easily invalidate the cache on this page: https://github.com/microsoft/yardl/actions/caches.
No description provided.